upstream: Add HttpPoolData methods required by Nighthawk. #16865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Sobon <mumak@google.com>
|
@alyssawilk this PR attempts to pave a path towards the removal of the workaround in Nighthawk. I would appreciate if you could take a look. |
alyssawilk
approved these changes
Jun 8, 2021
mum4k
added a commit
to mum4k/nighthawk
that referenced
this pull request
Jun 8, 2021
- Removing reference to header file `transport_sockets/well_known_names.h` that was deleted by Envoy (envoyproxy/envoy@97d4792). - Undoing temporary workaround for Nighthawk's pool access now that envoyproxy/envoy#16865 was merged in. Fixes envoyproxy#695. Signed-off-by: Jakub Sobon <mumak@google.com>
This was referenced Jun 8, 2021
mum4k
added a commit
to envoyproxy/nighthawk
that referenced
this pull request
Jun 8, 2021
- Removing reference to header file `transport_sockets/well_known_names.h` that was deleted by Envoy (envoyproxy/envoy@97d4792). - Undoing temporary workaround for Nighthawk's pool access now that envoyproxy/envoy#16865 was merged in. Fixes #695. Signed-off-by: Jakub Sobon <mumak@google.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
A recent change (envoyproxy#16544) moved the Http::ConnectionPool::Instance* returned from ThreadLocalCluster::httpConnPool() behind a new class HttpPoolData which no longer exposes the pool instance. This PR adds two new methods on HttpPoolData to allow the removal of said workaround - hasActiveConnections and addDrainedCallback. Both just forward the call to the underlying pool. Risk Level: low, existing functionality isn't affected. Testing: n/a, only accessor method added. Docs Changes: n/a. Release Notes: n/a. Signed-off-by: Jakub Sobon <mumak@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change (#16544) moved the
Http::ConnectionPool::Instance*returned fromThreadLocalCluster::httpConnPool()behind a new classHttpPoolDatawhich no longer exposes the pool instance.A temporary workaround was added to Nighthawk's code here to support the this code.
This PR adds two new methods on
HttpPoolDatato allow the removal of said workaround -hasActiveConnectionsandaddDrainedCallback. Both just forward the call to the underlying pool.Risk Level: low, existing functionality isn't affected.
Testing: n/a, only accessor method added.
Docs Changes: n/a.
Release Notes: n/a.
Signed-off-by: Jakub Sobon mumak@google.com